Re: [PATCH v10 1/2] gpio: loongson: add gpio driver support
From: Bartosz Golaszewski
Date: Sat Dec 03 2022 - 12:45:20 EST
On Sat, Dec 3, 2022 at 4:41 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Sat, Dec 03, 2022 at 05:27:31PM +0200, Andy Shevchenko wrote:
> > On Sat, Dec 03, 2022 at 06:53:20PM +0800, Yinbo Zhu wrote:
> > > 在 2022/12/3 18:03, Linus Walleij 写道:
> > > > On Thu, Dec 1, 2022 at 1:33 PM Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> wrote:
> > > > > +config GPIO_LOONGSON_64BIT
> > > > > + tristate "Loongson 64 bit GPIO support"
> > > > > + depends on LOONGARCH || COMPILE_TEST
> > > > > + select GPIO_GENERIC
> > > > > + select GPIOLIB_IRQCHIP
> > > > If the kernelbots start complaining you might need to add a:
> > > >
> > > > select IRQ_DOMAIN_HIERARCHY
> > > >
> > > > here.
> > >
> > > Bartosz had merged my patch and I will add a change on top of the existing
> > > series.
> >
> > I don;'t know why he had done that, the driver requires a lot of cleanups,
> > e.g. why it uses acpi.h, what that "nice" container of the platform device for.
>
> + we have macros for get_direction() returned values and so on.
>
You'll have the chance to review Yinbo's patches Andy because the
driver fails to build with current next. I didn't notice the code
references of_nodes even though they're gone now from struct
gpio_chip. I need to back it out and let's get back to it for the next
release.
Bartosz