Re: [PATCH] usb: fotg210-udc: fix potential memory leak in fotg210_udc_probe()

From: Linus Walleij
Date: Sun Dec 04 2022 - 13:19:28 EST


On Wed, Nov 30, 2022 at 11:15 AM Yi Yang <yiyang13@xxxxxxxxxx> wrote:

> In fotg210_udc_probe(), if devm_clk_get() or clk_prepare_enable()
> fails, 'fotg210' will not be freed, which will lead to a memory leak.
> Fix it by moving kfree() to a proper location.
>
> Fixes: 718a38d092ec ("fotg210-udc: Handle PCLK")
> Signed-off-by: Yi Yang <yiyang13@xxxxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij