Re: [PATCH 8/9] media: dt-bindings: nvidia,tegra-cec: convert to DT schema

[Hans Verkuil]

On 04/12/2022 19:29, Krzysztof Kozlowski wrote:
> Convert Nvidia Tegra HDMI CEC bindings to DT schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Acked-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>

Thanks!

	Hans

> ---
>  .../bindings/media/cec/nvidia,tegra-cec.yaml  | 58 +++++++++++++++++++
>  .../devicetree/bindings/media/tegra-cec.txt   | 27 ---------
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 59 insertions(+), 28 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml
>  delete mode 100644 Documentation/devicetree/bindings/media/tegra-cec.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml b/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml
> new file mode 100644
> index 000000000000..9a4025ff7fad
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/cec/nvidia,tegra-cec.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nvidia Tegra HDMI CEC
> +
> +maintainers:
> +  - Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
> +
> +allOf:
> +  - $ref: cec-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nvidia,tegra114-cec
> +      - nvidia,tegra124-cec
> +      - nvidia,tegra210-cec
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: cec
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - clocks
> +  - clock-names
> +  - hdmi-phandle
> +  - interrupts
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/tegra124-car.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    cec@70015000 {
> +        compatible = "nvidia,tegra124-cec";
> +        reg = <0x70015000 0x00001000>;
> +        interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> +        clocks = <&tegra_car TEGRA124_CLK_CEC>;
> +        clock-names = "cec";
> +        status = "disabled";
> +        hdmi-phandle = <&hdmi>;
> +    };
> diff --git a/Documentation/devicetree/bindings/media/tegra-cec.txt b/Documentation/devicetree/bindings/media/tegra-cec.txt
> deleted file mode 100644
> index c503f06f3b84..000000000000
> --- a/Documentation/devicetree/bindings/media/tegra-cec.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -* Tegra HDMI CEC hardware
> -
> -The HDMI CEC module is present in Tegra SoCs and its purpose is to
> -handle communication between HDMI connected devices over the CEC bus.
> -
> -Required properties:
> -  - compatible : value should be one of the following:
> -	"nvidia,tegra114-cec"
> -	"nvidia,tegra124-cec"
> -	"nvidia,tegra210-cec"
> -  - reg : Physical base address of the IP registers and length of memory
> -	  mapped region.
> -  - interrupts : HDMI CEC interrupt number to the CPU.
> -  - clocks : from common clock binding: handle to HDMI CEC clock.
> -  - clock-names : from common clock binding: must contain "cec",
> -		  corresponding to the entry in the clocks property.
> -  - hdmi-phandle : phandle to the HDMI controller, see also cec.txt.
> -
> -Example:
> -
> -cec@70015000 {
> -	compatible = "nvidia,tegra124-cec";
> -	reg = <0x0 0x70015000 0x0 0x00001000>;
> -	interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> -	clocks = <&tegra_car TEGRA124_CLK_CEC>;
> -	clock-names = "cec";
> -};
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 197351d3bb57..dee3f776be32 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2999,7 +2999,7 @@ M:	Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
>  L:	linux-tegra@xxxxxxxxxxxxxxx
>  L:	linux-media@xxxxxxxxxxxxxxx
>  S:	Maintained
> -F:	Documentation/devicetree/bindings/media/tegra-cec.txt
> +F:	Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml
>  F:	drivers/media/cec/platform/tegra/
>  
>  ARM/TESLA FSD SoC SUPPORT