Re: [PATCH v2 0/6] memory: renesas-rpc-if: Rebind fixes and misc cleanups

From: Wolfram Sang
Date: Mon Dec 05 2022 - 03:59:10 EST


On Wed, Nov 23, 2022 at 03:41:16PM +0100, Geert Uytterhoeven wrote:
> Hi all,
>
> The Renesas RPC-IF provides either HyperFlash or SPI host access.
> To handle this, three drivers are used:
> 1. The RPC-IF core diver,
> 2. An HyperFlash child driver,
> 3. An SPI child driver.
>
> Currently this driver collection suffers from a sub-optimal division of
> roles and reponsibilities, leading to (un)bind issues: after manually
> unbinding the child driver, rebinding the child driver fails with
> -EBUSY.
>
> This patch series aims to fix this, by splitting off private data and
> making the RPC-IF core driver responsible for resource acquisition.
> After that, a few customary cleanups are provided.
>
> This has been tested on the Salvator-X(S) and Ebisu-4D (HyperFlash) and
> White-Hawk (QSPI FLASH) development boards.

Sadly, I don't have the bandwidth to do a full review. But from a
glimpse, it all looks good. And from a high level PoV, this all makes a
lot of sense. So:

Acked-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature