Re: [PATCH v1] Revert "cpufreq: schedutil: Move max CPU capacity to sugov_policy"
From: Viresh Kumar
Date: Mon Dec 05 2022 - 04:19:09 EST
Lukasz,
On 10-11-22, 19:57, Sam Wu wrote:
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index 9161d1136d01..1207c78f85c1 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -25,9 +25,6 @@ struct sugov_policy {
> unsigned int next_freq;
> unsigned int cached_raw_freq;
>
> - /* max CPU capacity, which is equal for all CPUs in freq. domain */
> - unsigned long max;
> -
> /* The next fields are only needed if fast switch cannot be used: */
> struct irq_work irq_work;
> struct kthread_work work;
> @@ -51,6 +48,7 @@ struct sugov_cpu {
>
> unsigned long util;
> unsigned long bw_dl;
> + unsigned long max;
IIUC, this part, i.e. moving max to sugov_policy, wasn't the problem
here, right ? Can you send a patch for that at least first, since this
is fully reverted now.
Or it doesn't make sense?
--
viresh