Re: [PATCH 1/2] Documentation/features-refresh.sh: Only sed the beginning "arch" of ARCH_DIR

From: Jonathan Corbet
Date: Mon Dec 05 2022 - 05:02:31 EST


Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> writes:

> It should only sed the beginning "arch" of ARCH_DIR in features-refresh.sh,
> otherwise loongarch is recognized as loong, that is not what we want.
>
> Fixes: be99f610a110 ("Documentation/features: Add script that refreshes the arch support status files in place")
> Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
> ---
> Documentation/features/scripts/features-refresh.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/features/scripts/features-refresh.sh b/Documentation/features/scripts/features-refresh.sh
> index 9e72d38..c228812 100755
> --- a/Documentation/features/scripts/features-refresh.sh
> +++ b/Documentation/features/scripts/features-refresh.sh
> @@ -60,7 +60,7 @@ for F_FILE in Documentation/features/*/*/arch-support.txt; do
> echo " | arch |status|" >> $T_FILE
> echo " -----------------------" >> $T_FILE
> for ARCH_DIR in arch/*/; do
> - ARCH=$(echo $ARCH_DIR | sed -e 's/arch//g' | sed -e 's/\///g')
> + ARCH=$(echo $ARCH_DIR | sed -e 's/^arch//g' | sed -e 's/\///g')

So ... looking at this now, it strikes me as a bit of a convoluted way
to reimplement "basename" - obviously incorrectly before this fix. Oh
well, this is better than before, so I've applied the series.

Thanks,

jon