Re: [PATCH v2] media: uvcvideo: Recover stalled ElGato devices

From: Sergey Senozhatsky
Date: Mon Dec 05 2022 - 06:57:22 EST


On (22/12/02 18:01), Ricardo Ribalda wrote:
> Elgato Cam Link 4k can be in a stalled state if the resolution of
> the external source has changed while the firmware initializes.
> Once in this state, the device is useless until it receives a
> USB reset. It has even been observed that the stalled state will
> continue even after unplugging the device.
>
> lsusb -v
>
> Bus 002 Device 002: ID 0fd9:0066 Elgato Systems GmbH Cam Link 4K
> Device Descriptor:
> bLength 18
> bDescriptorType 1
> bcdUSB 3.00
> bDeviceClass 239 Miscellaneous Device
> bDeviceSubClass 2
> bDeviceProtocol 1 Interface Association
> bMaxPacketSize0 9
> idVendor 0x0fd9 Elgato Systems GmbH
> idProduct 0x0066
> bcdDevice 0.00
> iManufacturer 1 Elgato
> iProduct 2 Cam Link 4K
> iSerial 4 0005AC52FE000
> bNumConfigurations 1
>
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>

Reviewed-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>

>
> +static const struct usb_device_id elgato_cam_link_4k = {
> + USB_DEVICE(0x0fd9, 0x0066)};
> +

A nit, I'd format this slightly different:

+static const struct usb_device_id elgato_cam_link_4k = {
+ USB_DEVICE(0x0fd9, 0x0066)
+};