Re: [PATCH net-next v1 01/13] net: wwan: tmi: Add PCIe core

[AngeloGioacchino Del Regno]

Il 05/12/22 13:40, Yanchao Yang (杨彦超) ha scritto:
> On Thu, 2022-11-24 at 12:06 +0100, AngeloGioacchino Del Regno wrote:
> > Il 22/11/22 12:11, Yanchao Yang ha scritto:
> > > From: MediaTek Corporation <linuxwwan@xxxxxxxxxxxx>
> > >
> > > Registers the TMI device driver with the kernel. Set up all the
> > > fundamental
> > > configurations for the device: PCIe layer, Modem Host Cross Core
> > > Interface
> > > (MHCCIF), Reset Generation Unit (RGU), modem common control
> > > operations and
> > > build infrastructure.
> > >
> > > * PCIe layer code implements driver probe and removal, MSI-X
> > > interrupt
> > > initialization and de-initialization, and the way of resetting the
> > > device.
> > > * MHCCIF provides interrupt channels to communicate events such as
> > > handshake,
> > > PM and port enumeration.
> > > * RGU provides interrupt channels to generate notifications from
> > > the device
> > > so that the TMI driver could get the device reset.
> > > * Modem common control operations provide the basic read/write
> > > functions of
> > > the device's hardware registers, mask/unmask/get/clear functions of
> > > the
> > > device's interrupt registers and inquiry functions of the device's
> > > status.
> > >
> > > Signed-off-by: Ting Wang <ting.wang@xxxxxxxxxxxx>
> > > Signed-off-by: MediaTek Corporation <linuxwwan@xxxxxxxxxxxx>
>
> Hello Angelo,
>
> > Hello Yanchao,
> > thanks for the patch! However, there are some things to improve...
> >
> > First of all, you have to signoff (in your name) all patches that you
> > send.
>
> Thank your suggestion. Fix it next version (add Signed-off-by: Yanchao
> Yang <yanchao.yang@xxxxxxxxxxxx> for all patches)
> > Check below for more comments...
> >
> > > ---

..snip.. :-)

There's a misunderstanding here: when I write

"..snip.."

I mean "I'm snipping out lines of code for which I have no comments, or
for which comments are redundant"

I do that to increase readability of reviews and decrease the size of the
mail that's going out, nothing else.

> > > +	u32 (*read32)(struct mtk_md_dev *mdev, u64 addr);
> >
> > ..snip..
>
> do you mean we should remove read function wrapper?

No, that's fine.

Regards,
Angelo