Re: [PATCH v2] x86/sev: Add SEV-SNP guest feature negotiation support

[Borislav Petkov]

On Mon, Dec 05, 2022 at 09:23:17AM -0600, Tom Lendacky wrote:
> This makes it sound like these features are required to run SNP, which
> they're not. It's that we can't run SNP with these features without support
> in the guest. So while the patch name is long, it is accurate.

Maybe, but it is a mouthful this way. And unreadable. And there's plenty
of comments explaining what it is. And it is used in one place only.

> Maybe SNP_FEATURES_NEED_IMPLEMENTATION if you want to shorten it a little?

"need implementation" where? Host? Guest?

I.e., we're relying on comments to explain what the name is, one way or
the other.

How about a short and sweet:

		if (sev_status & SNP_FEATURES_IMPL_REQ & ~SNP_FEATURES_PRESENT)

along with the explanation in a comment above it. Comment which is a
must regardless.

Hmm.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette