Re: [linus:master] [KVM] 92e7d5c83a: kernel-selftests.kvm.triple_fault_event_test.fail
From: Sean Christopherson
Date: Mon Dec 05 2022 - 12:32:31 EST
On Sat, Dec 03, 2022, kernel test robot wrote:
>
> Greeting,
>
> FYI, we noticed kernel-selftests.kvm.triple_fault_event_test.fail due to commit (built with gcc-11):
>
> commit: 92e7d5c83aff124f49082585e57939ed24b59c5c ("KVM: x86: allow L1 to not intercept triple fault")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
Should already be fixed. Thanks!
commit df0bb47baa95aad133820b149851d5b94cbc6790
Author: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Wed Nov 30 11:14:35 2022 -0500
KVM: x86: fix uninitialized variable use on KVM_REQ_TRIPLE_FAULT
If a triple fault was fixed by kvm_x86_ops.nested_ops->triple_fault (by
turning it into a vmexit), there is no need to leave vcpu_enter_guest().
Any vcpu->requests will be caught later before the actual vmentry,
and in fact vcpu_enter_guest() was not initializing the "r" variable.
Depending on the compiler's whims, this could cause the
x86_64/triple_fault_event_test test to fail.
Cc: Maxim Levitsky <mlevitsk@xxxxxxxxxx>
Fixes: 92e7d5c83aff ("KVM: x86: allow L1 to not intercept triple fault")
Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>