Re: [PATCH] block: sed-opal: Don't include <linux/kernel.h>

From: Christophe JAILLET
Date: Mon Dec 05 2022 - 14:11:00 EST


Le 05/12/2022 à 08:10, Christoph Hellwig a écrit :
On Sat, Dec 03, 2022 at 01:18:49PM +0100, Christophe JAILLET wrote:
#include <uapi/linux/sed-opal.h>
-#include <linux/kernel.h>
+
+#include <linux/compiler_types.h> /* for __user */

Not sure we really need the comment here, we don't comment on the
other includes either. Also why the added empty line?


Ok for the comment, I'll remove it.
In header files, sometimes, when not obvious, we find such comments. Sometimes we don't.

For the empty line, it was mostly a matter of taste. My goal was to explicitly show that one was <uapi/linux, and the other one only <linux/

I'll remove it as well.

My main point, was only to remove kernel.h.

CJ