Re: [PATCH v4 16/23] scsi: ufs: ufs-qcom: Use dev_err_probe() for printing probe error

[Asutosh Das]

On Thu, Dec 01 2022 at 09:45 -0800, Manivannan Sadhasivam wrote:
> Make use of dev_err_probe() for printing the probe error.
>
> Reviewed-by: Andrew Halaney <ahalaney@xxxxxxxxxx>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> ---
> drivers/ufs/host/ufs-qcom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Asutosh Das <quic_asutoshd@xxxxxxxxxxx>



> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 8bb0f4415f1a..38e2ed749d75 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1441,9 +1441,9 @@ static int ufs_qcom_probe(struct platform_device *pdev)
> 	/* Perform generic probe */
> 	err = ufshcd_pltfrm_init(pdev, &ufs_hba_qcom_vops);
> 	if (err)
> -		dev_err(dev, "ufshcd_pltfrm_init() failed %d\n", err);
> +		return dev_err_probe(dev, err, "ufshcd_pltfrm_init() failed\n");
>
> -	return err;
> +	return 0;
> }
>
> /**
> --
> 2.25.1