Re: [PATCH v3 1/9] blk-throttle: correct stale comment in throtl_pd_init
From: Jens Axboe
Date: Mon Dec 05 2022 - 15:43:40 EST
On 12/5/22 4:57?AM, Kemeng Shi wrote:
> From: Kemeng Shi <shikemeng@xxxxxxxxxx>
>
> On the default hierarchy (cgroup2), the throttle interface files don't
> exist in the root cgroup, so the ablity to limit the whole system
> by configuring root group is not existing anymore. In general, cgroup
> doesn't wanna be in the business of restricting resources at the
> system level, so correct the stale comment that we can limit whole
> system to we can only limit subtree.
>
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxx>
> Acked-by: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>
Which one should be used? You have duplicate SOBs in each of the
commits. It's marked as being from Kemeng Shi <shikemeng@xxxxxxxxxx> so
that is what I'll use.
--
Jens Axboe