Re: [PATCH v8 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

From: Dmitry Baryshkov
Date: Mon Dec 05 2022 - 16:34:25 EST




On 5 December 2022 22:14:27 GMT+03:00, Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx> wrote:
>Add both data-lanes and link-frequencies property into endpoint
>
>Changes in v7:
>-- split yaml out of dtsi patch
>-- link-frequencies from link rate to symbol rate
>-- deprecation of old data-lanes property
>
>Changes in v8:
>-- correct Bjorn mail address to kernel.org
>
>Signed-off-by: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>
>---
> .../bindings/display/msm/dp-controller.yaml | 22 ++++++++++++++++------
> 1 file changed, 16 insertions(+), 6 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>index f2515af..13d2c3c 100644
>--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>@@ -79,12 +79,6 @@ properties:
> aux-bus:
> $ref: /schemas/display/dp-aux-bus.yaml#
>
>- data-lanes:
>- $ref: /schemas/types.yaml#/definitions/uint32-array
>- minItems: 1
>- maxItems: 4
>- items:
>- maximum: 3

These properties can still be used, e.g. Bjorn is submitting patches with the old property. I think this should be marked with deprecated: true instead of removal.

>
> "#sound-dai-cells":
> const: 0
>@@ -105,6 +99,19 @@ properties:
> $ref: /schemas/graph.yaml#/properties/port
> description: Output endpoint of the controller
>
>+ properties:
>+ endpoint:
>+ $ref: /schemas/media/video-interfaces.yaml#
>+
>+ properties:
>+ data-lanes:
>+ $ref: /schemas/types.yaml#/definitions/uint32-array
>+
>+ link-frequencies:
>+ $ref: /schemas/types.yaml#/definitions/uint64-array
>+
>+ additionalProperties: false
>+
> required:
> - compatible
> - reg
>@@ -193,6 +200,9 @@ examples:
> reg = <1>;
> endpoint {
> remote-endpoint = <&typec>;
>+ data-lanes = <1 2>;
>+ link-frequencies = /bits/ 64 <1620000000 2700000000
>+ 5400000000 8100000000>;
> };
> };
> };

--
With best wishes
Dmitry