Re: [PATCH] net/ncsi: Silence runtime memcpy() false positive warning
From: Paolo Abeni
Date: Tue Dec 06 2022 - 05:38:01 EST
Hello,
On Fri, 2022-12-02 at 13:24 -0800, Kees Cook wrote:
> The memcpy() in ncsi_cmd_handler_oem deserializes nca->data into a
> flexible array structure that overlapping with non-flex-array members
> (mfr_id) intentionally. Since the mem_to_flex() API is not finished,
> temporarily silence this warning, since it is a false positive, using
> unsafe_memcpy().
>
> Reported-by: Joel Stanley <joel@xxxxxxxxx>
> Link: https://lore.kernel.org/netdev/CACPK8Xdfi=OJKP0x0D1w87fQeFZ4A2DP2qzGCRcuVbpU-9=4sQ@xxxxxxxxxxxxxx/
> Cc: Samuel Mendoza-Jonas <sam@xxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
Is this for the -net or the -net-next tree? It applies to both...
It you are targetting the -net tree, I think it would be nicer adding a
suitable Fixes tag.
Thanks!
Paolo