Re: [next v7 0/8] Add BananaPi R3
From: Lorenzo Pieralisi
Date: Tue Dec 06 2022 - 06:32:46 EST
On Sun, Nov 27, 2022 at 12:41:34PM +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> This Series adds some Nodes to mt7986 devicetree and the BananaPi R3
>
> This version is rebased on linux next from 2022/11/27.
>
> i included sams series for mt7986 DTS with small changes
> https://patchwork.kernel.org/project/linux-mediatek/cover/20220427124741.18245->
>
> i had run full dtbs-check but i end up with some strange warnings in
> ethernet-node that should not come up as phy-handle and sfp/managed
> properties are already defined. These errors also came up for mt7986a-rfb.
>
> phy-handle made optional
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/mediatek,net.yaml#n265
>
> property sfp/managed (which is included for mac subnode in yaml above):
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/ethernet-controller.yaml#n137
>
> changes:
> v7:
> - rebase on next so dropped already applied patches
> - squashed overlay-patch into the bpi-r3 base support
> - moved regulators from mmc-dts to common dtsi
> - changed dtsi to dts (as board base dtb) and mmc-dts to overlays
> - renamed overlays to dtso
> - removed angelos RB because of changes in bpi-r3 patch
>
> v6:
> - dropped regulators from usb-patch as suggested by chunfeng yun
> - moved 3v3 regulator to mmc-patch as it is needed for emmc to work
> rfbs were tested by sam shih, r3 by me
> - dropped RB from AngeloGioacchino from mmc-patch due to this change
> - fixed links in coverletter which were broken in v5
> - i hope this series is sent without errors now (my mailprovider limited
> mails last 2 times while sending part 10)
>
> v5:
> - changed usb ranges/reg/unit-adress
> - added reviewd-by's except usb-part due to changes
>
> v4:
> - dropped RFC prefix
> - rebase on matthias' mtk dts-next (for 6.2) branch
> - added author information to overlays
> - fixed sfp binding error
> - added fix for moving wed_pcie node
> - readded missing compatible patches
>
> v3:
> - changed mmc pull-ups
> - added patch for board binding (sent separately before)
> - added pcie node in mt7986 (not yet again in r3)
> - added dt overlays
>
> Frank Wunderlich (5):
> dt-bindings: phy: mediatek,tphy: add support for mt7986
> dt-bindings: usb: mtk-xhci: add support for mt7986
> dt-bindings: PCI: mediatek-gen3: add SoC based clock config
> dt-bindings: PCI: mediatek-gen3: add support for mt7986
> arm64: dts: mt7986: add Bananapi R3
>
> Sam Shih (3):
> arm64: dts: mt7986: add usb related device nodes
> arm64: dts: mt7986: add mmc related device nodes
> arm64: dts: mt7986: add pcie related device nodes
>
> .../bindings/pci/mediatek-pcie-gen3.yaml | 64 ++-
> .../bindings/phy/mediatek,tphy.yaml | 1 +
> .../bindings/usb/mediatek,mtk-xhci.yaml | 1 +
> arch/arm64/boot/dts/mediatek/Makefile | 5 +
> .../mt7986a-bananapi-bpi-r3-emmc.dtso | 30 ++
> .../mt7986a-bananapi-bpi-r3-nand.dtso | 55 +++
> .../mediatek/mt7986a-bananapi-bpi-r3-nor.dtso | 68 +++
> .../mediatek/mt7986a-bananapi-bpi-r3-sd.dtso | 24 +
> .../dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 448 ++++++++++++++++++
> arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 120 +++++
> arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 122 +++++
> arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts | 8 +
> 12 files changed, 934 insertions(+), 12 deletions(-)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-emmc.dtso
> create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nand.dtso
> create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dtso
> create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-sd.dtso
> create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
Should I pick up patches [3,4] into the PCI tree ?
Thanks,
Lorenzo