Re: [PATCH] Linux: SPI: add Gigadevice part #

[Frieder Schrempf]

On 06.12.22 09:18, Miquel Raynal wrote:
> Hi Vlim,
> 
> vlim@xxxxxxxxxxxxxx wrote on Tue, 6 Dec 2022 01:27:13 +0000:
> 
>> Hi, Michael,
>>
>> I will redo the patch following this doc.
>> At the meantime, can you point out a few mistakes that I am making so that I can correct it in the next submit.
> 
> Here are a few:
> - The title is wrong (git log --oneline <file> for hints)
> - The commit log is useless
> - Don't make unrelated changes in your commit, one change == one commit
> - Don't change how the code looks like for no reason or justification
> 
> And please avoid top posting when answering.

Here are some more:

* sending (almost) the same wrong patch again ignoring feedback from
maintainers
* not using version prefixes in your subject line (PATCH v2: ...)
* not adding a changelog to your patch
* keeping your replies off the mailing list (probably your @gigadevice
address is not subscribed!?)