Re: [PATCH] trace: Fix some checker warnings

From: Google
Date: Tue Dec 06 2022 - 08:59:35 EST


On Mon, 05 Dec 2022 10:29:46 +0000
David Howells <dhowells@xxxxxxxxxx> wrote:

> Btw, do you know how to deal with:
>
> add_ftrace_export(struct trace_export **list, struct trace_export *export)
>
> being called by:
>
> add_ftrace_export(&ftrace_exports_list, export);
>
> but ftrace_exports_list has an __rcu annotation, so the list argument in the
> former should have an __rcu annotation in it somewhere too.

Can't you just add __rcu to the 'list' argument?

>
> OTOH - there's only one user of add_trace_export() and add_ftrace_export(), so
> can they be collapsed into register_ftrace_export()?

Steve, do you have any idea?

Thanks,

>
> David
>


--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>