Re: [PATCH v6 02/10] arm64: dts: qcom: Add base SM8550 dtsi

[Sai Prakash Ranjan]

Hi Abel,

On 12/6/2022 6:42 PM, Abel Vesa wrote:
> Add base dtsi for SM8550 SoC and includes base description of
> CPUs, GCC, RPMHCC, UART, interrupt controller, TLMM, reserved
> memory, RPMh PD, TCSRCC, ITS, IPCC, AOSS QMP, LLCC, cpufreq,
> interconnect, thermal sensor, cpu cooling maps and SMMU nodes
> which helps boot to shell with console on boards with this SoC.
>
> Co-developed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
>
> Changes since v5:
>   * changed the include of qcom,sm8550-tcsrcc.h to qcom,sm8550-tcsr.h

<snip>...


> +	pmu {
> +		compatible = "arm,armv8-pmuv3";
> +		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;

This should be IRQ_TYPE_LEVEL_LOW


> +
> +		intc: interrupt-controller@17100000 {
> +			compatible = "arm,gic-v3";
> +			reg = <0 0x17100000 0 0x10000>,	/* GICD */
> +			      <0 0x17180000 0 0x200000>;	/* GICR * 8 */
> +			ranges;
> +			#interrupt-cells = <3>;
> +			interrupt-controller;
> +			#redistributor-regions = <1>;
> +			redistributor-stride = <0 0x40000>;
> +			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;

And here as well, IRQ_TYPE_LEVEL_LOW

With these 2 corrections,

Reviewed-by: Sai Prakash Ranjan <quic_saipraka@xxxxxxxxxxx>


Thanks,
Sai