Re: [PATCH 1/2] RISC-V: kexec: Fix memory leak of fdt buffer
From: Li Huafei
Date: Tue Dec 06 2022 - 20:25:34 EST
On 2022/12/6 6:28, Palmer Dabbelt wrote:
> On Fri, 4 Nov 2022 17:56:57 +0800, Li Huafei wrote:
>> This is reported by kmemleak detector:
>>
>> unreferenced object 0xff60000082864000 (size 9588):
>> comm "kexec", pid 146, jiffies 4294900634 (age 64.788s)
>> hex dump (first 32 bytes):
>> d0 0d fe ed 00 00 12 ed 00 00 00 48 00 00 11 40 ...........H...@
>> 00 00 00 28 00 00 00 11 00 00 00 02 00 00 00 00 ...(............
>> backtrace:
>> [<00000000f95b17c4>] kmemleak_alloc+0x34/0x3e
>> [<00000000b9ec8e3e>] kmalloc_order+0x9c/0xc4
>> [<00000000a95cf02e>] kmalloc_order_trace+0x34/0xb6
>> [<00000000f01e68b4>] __kmalloc+0x5c2/0x62a
>> [<000000002bd497b2>] kvmalloc_node+0x66/0xd6
>> [<00000000906542fa>] of_kexec_alloc_and_setup_fdt+0xa6/0x6ea
>> [<00000000e1166bde>] elf_kexec_load+0x206/0x4ec
>> [<0000000036548e09>] kexec_image_load_default+0x40/0x4c
>> [<0000000079fbe1b4>] sys_kexec_file_load+0x1c4/0x322
>> [<0000000040c62c03>] ret_from_syscall+0x0/0x2
>>
>> [...]
>
> Applied, thanks!
>
> [1/2] RISC-V: kexec: Fix memory leak of fdt buffer
> https://git.kernel.org/palmer/c/96df59b1ae23
> [2/2] RISC-V: kexec: Fix memory leak of elf header buffer
> https://git.kernel.org/palmer/c/cbc32023ddbd
>
> These are on for-next. They'd probably be fine fixes candidates had I gotten
> to them in time, but it's pretty late and a leak during kexec doesn't seem like
> a show-stopper. They'll get backported anyway, but this way they get an extra
> week in linux-next just to see.
>
I have no problem with it being merged into the -next branch. Thanks Palmer!
> Best regards,
>