Re: [PATCH] platform/chrome: cros_ec_typec: zero out stale pointers
From: Prashant Malani
Date: Wed Dec 07 2022 - 03:02:19 EST
Hi Victor,
On Tue, Dec 6, 2022 at 8:02 PM Victor Ding <victording@xxxxxxxxxxxx> wrote:
>
> `cros_typec_get_switch_handles` allocates several pointers when
> obtaining four handles. These pointers are all freed if failing to
> obtain any of the four handles; therefore, pointers in `port` becomes
> stale. The stale pointers eventually cause use-after-free or double in
> later code paths.
>
> This patch proposes
Please use the imperative form [1]
> to elimite these stale pointers by zeroing them out
s/elimite/eliminate
> right after they are freed.
>
> Signed-off-by: Victor Ding <victording@xxxxxxxxxxxx>
This should have a "Fixes" tag.
Best regards,
-Prashant
[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes