Re: [PATCH] iio: magnetometer: bmc150_magn: Convert to use sysfs_emit_at() API

[Andy Shevchenko]

On Wed, Dec 7, 2022 at 9:49 AM <ye.xingchen@xxxxxxxxxx> wrote:
>
> From: ye xingchen <ye.xingchen@xxxxxxxxxx>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxx>

> Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx>
> ---
>  drivers/iio/magnetometer/bmc150_magn.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
> index 06d5a1ef1fbd..1398684a7f30 100644
> --- a/drivers/iio/magnetometer/bmc150_magn.c
> +++ b/drivers/iio/magnetometer/bmc150_magn.c
> @@ -598,8 +598,7 @@ static ssize_t bmc150_magn_show_samp_freq_avail(struct device *dev,
>         for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) {
>                 if (bmc150_magn_samp_freq_table[i].freq > data->max_odr)
>                         break;
> -               len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
> -                                bmc150_magn_samp_freq_table[i].freq);
> +               len += sysfs_emit_at(buf, len, "%d ", bmc150_magn_samp_freq_table[i].freq);
>         }
>         /* replace last space with a newline */
>         buf[len - 1] = '\n';
> --
> 2.25.1



-- 
With Best Regards,
Andy Shevchenko