Re: [PATCH v5] wifi: rtl8xxxu: fixing IQK failures for rtl8192eu
From: Kalle Valo
Date: Wed Dec 07 2022 - 07:31:37 EST
Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes:
>> >> Fixing "Path A RX IQK failed" and "Path B RX IQK failed"
>> >> issues for rtl8192eu chips by replacing the arguments with
>> >> the ones in the updated official driver as shown below.
>> >> 1. https://github.com/Mange/rtl8192eu-linux-driver
>> >> 2. vendor driver version: 5.6.4
>> >>
>> >> Tested-by: Jun ASAKA <JunASAKA@xxxxxxxxxxxxx>
>> >> Signed-off-by: Jun ASAKA <JunASAKA@xxxxxxxxxxxxx>
The assumption is that the patch submitter tests the patches, so a
separate Tested-by tag is not needed. I'll remove it.
>> >> Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>> >> ---
>> >> v5:
>> >> - no modification.
>> > Then, why do you need v5?
>> Well, I just want to add the "Reviewed-By" line to the commit message.
>> Sorry for the noise if there is no need to do that.
>
> No need to add "Reviewed-By". Kalle will add it when this patch gets merged.
Yeah. And to be precise patchwork actually does that automatically, a
very nice feature :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches