Re: [PATCH 1/2] spi: spi-fsl-lpspi: support multiple cs for lpspi
From: Mark Brown
Date: Wed Dec 07 2022 - 08:44:26 EST
On Wed, Dec 07, 2022 at 12:08:43PM +0530, Dhruva Gole wrote:
> On 07/12/22 04:24, Han Xu wrote:
> > support to get chip select number from DT file.
> > + fsl_lpspi->num_cs = 1;
> I am not sure I understand why you are setting this to 1 here?
> I am assuming it is because you want num_cs to default to 1 if
> it is not specified in DT.
> Please can you also add a dev_err and be sure to warn about this?
The binding says that this property is optional with a default of 1 so
it should be totally fine for a system to not specify anything.
Attachment:
signature.asc
Description: PGP signature