Re: [PATCH 0/7] powerpc/85xx: p2020: Create one unified machine description

[Christophe Leroy]

Le 04/12/2022 à 11:54, Pali Rohár a écrit :
> On Friday 19 August 2022 21:15:50 Pali Rohár wrote:
>> This patch series unifies all P2020 boards and machine descriptions into
>> one generic unified P2020 machine description. With this generic machine
>> description, kernel can boot on any P2020-based board with correct DTS
>> file.
>>
>> Tested on CZ.NIC Turris 1.1 board with has Freescale P2020 processor.
>> Kernel during booting correctly detects P2020 and prints:
>> [    0.000000] Using Freescale P2020 machine description
>>
>> Pali Rohár (7):
>>    powerpc/85xx: Mark mpc85xx_rdb_pic_init() as static
>>    powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
>>    powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c
>>    powerpc/85xx: p2020: Unify .setup_arch and .init_IRQ callbacks
>>    powerpc/85xx: p2020: Define just one machine description
>>    powerpc/85xx: p2020: Enable boards by new config option CONFIG_P2020
>>    powerpc: dts: turris1x.dts: Remove "fsl,P2020RDB-PC" compatible string
> 
> Christophe, could you please summarize for me what is needed to change /
> fix / adjust in this patch series? We had discussion about all patches
> in this thread but I have not received reply for every my reaction. And
> I'm not sure what to do and what not. So I can prepare a V2 version.

I've been through all comments and answers once more. If I don't reply 
to your explanation, it means I agree with it.

So I think you can proceed now with v2.

> 
>>   arch/powerpc/boot/dts/turris1x.dts            |   2 +-
>>   arch/powerpc/platforms/85xx/Kconfig           |  22 ++-
>>   arch/powerpc/platforms/85xx/Makefile          |   1 +
>>   arch/powerpc/platforms/85xx/mpc85xx_ds.c      |  25 +--
>>   arch/powerpc/platforms/85xx/mpc85xx_rdb.c     |  46 +-----
>>   .../platforms/85xx/{mpc85xx_ds.c => p2020.c}  | 144 +++++++-----------
>>   6 files changed, 75 insertions(+), 165 deletions(-)
>>   copy arch/powerpc/platforms/85xx/{mpc85xx_ds.c => p2020.c} (53%)
>>
>> -- 
>> 2.20.1
>>