Re: [PATCH v2] drm/msm/dpu: Fix memory leak in msm_mdss_parse_data_bus_icc_path
From: Doug Anderson
Date: Wed Dec 07 2022 - 10:03:13 EST
Hi,
On Tue, Dec 6, 2022 at 10:59 PM Miaoqian Lin <linmq006@xxxxxxxxx> wrote:
>
> of_icc_get() alloc resources for path1, we should release it when not
> need anymore. Early return when IS_ERR_OR_NULL(path0) may leak path1.
> Defer getting path1 to fix this.
>
> Fixes: b9364eed9232 ("drm/msm/dpu: Move min BW request and full BW disable back to mdss")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> ---
> changes in v2:
> - move getting path1 after error check for path0.
> ---
> drivers/gpu/drm/msm/msm_mdss.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>