Re: [PATCH v11 5/6] dt-bindings: media: wave5: add yaml devicetree bindings
From: Krzysztof Kozlowski
Date: Wed Dec 07 2022 - 10:28:06 EST
On 07/12/2022 16:09, Sebastian Fricke wrote:
> Hello Krzysztof,
>
> On 07.12.2022 13:31, Krzysztof Kozlowski wrote:
>> On 07/12/2022 13:13, Sebastian Fricke wrote:
>>> From: Robert Beckett <bob.beckett@xxxxxxxxxxxxx>
>>>
>>> Add bindings for the wave5 chips&media codec driver
>>>
>>> Signed-off-by: Robert Beckett <bob.beckett@xxxxxxxxxxxxx>
>>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
>>> Signed-off-by: Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx>
>>
>> What's happening with this patch? Where is the changelog?
>
> The changelog is located in the cover letter.
> https://lore.kernel.org/linux-media/20221207121350.66217-1-sebastian.fricke@xxxxxxxxxxxxx/
Which you did not sent to us... so? How does it help us?
>
>> Why it is v11 and first time I see it?
>
> You actually replied to V10:
> https://lore.kernel.org/linux-media/20221023085341.s23qinjuw4qls3dn@basti-XPS-13-9310/
>
>> And why it is v11 with basic mistakes and lack of testing?!?
>> I would assume that v11 was already seen and tested...
>
> Sorry I don't have a lot of experience with dt-bindings, thank you for
> highlighting the issues, I will correct them. And I forgot to build the
> documentation during my testing runs.
> I took over the patch set from another contributor and as no one
> complained about the dt-bindings for the last 10 versions, I concentrated
> my energy on other problems.
Because they were never sent to maintainers...
>
>>
>>
>>> ---
>>> .../devicetree/bindings/cnm,wave5.yml | 72 +++++++++++++++++++
>>> 1 file changed, 72 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/cnm,wave5.yml
>>
>> Wrong directory. It wasn't here at all before, so I am really confused
>> how this could happen.
>
> Thanks for the highlight.
>
> I will move it to:
> Documentation/devicetree/bindings/media/cnm,wave5.yml
>
>>
>> Subject: drop redundant pieces: yaml, devicetree and bindings.
>
> I call it:
>
> dt-bindings: media: chips-media: add wave5 bindings
>
> in V12
>
> Sincerely,
> Sebastian Fricke
And the rest questions? Lack of response means agreement, which is fine,
so in v12 questionable parts will be removed?
Best regards,
Krzysztof