Re: [RFC PATCH v4 1/1] serial: core: Start managing serial controllers to enable runtime PM

From: Tony Lindgren
Date: Thu Dec 08 2022 - 01:06:40 EST


* Tony Lindgren <tony@xxxxxxxxxxx> [221208 05:52]:
> * Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> [221207 20:28]:
> > We can avoid this check by caching the platform device.
> >
> > struct platform_device *ctrl_pdev = NULL;
> >
> > if (...) {
> > ctrl_pdev = to_platform_device(ctrl_dev);
> > }
> >
> > platform_device_del(ctrl_pdev);
>
> OK yeah that's nicer :)
>
> > > Shouldn't you call platform_device_unregister()?
>
> Outside the error path it should be platform_device_unregister(),
> I'll check. Thanks also for your other comments.

To me looks like we should just use platform_device_unregister()
in call cases here like you noted.

Regards,

Tony