Re: [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example

From: Krzysztof Kozlowski
Date: Thu Dec 08 2022 - 03:08:02 EST


On 07/12/2022 06:53, Kunihiko Hayashi wrote:
> Rename the parent node to the generic node name "syscon".
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> index 14a8c0215cc6..186fc550af4c 100644
> --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> @@ -69,7 +69,7 @@ examples:
> - |
> // The UniPhier pinctrl should be a subnode of a "syscon" compatible node.
>
> - soc-glue@5f800000 {
> + syscon@5f800000 {
> compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon";
> reg = <0x5f800000 0x2000>;
>

Not visible in the diff but this is a poor example. It has only
compatible! Drop the parent node instead and extend the pinctrl node to
show complete picture of pinctrl.

Best regards,
Krzysztof