Re: [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part

[Krzysztof Kozlowski]

On 07/12/2022 06:53, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the SoC-glue logic debug part
> implemented on Socionext Uniphier SoCs.
> 
> This SoC-glue logic debug part is a set of miscellaneous function
> registers handling signals for specific devices outside system
> components, and also has multiple functions such as efuse, debug unit,
> several monitors for specific SoC, and so on.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> ---
>  .../socionext,uniphier-soc-glue-debug.yaml    | 73 +++++++++++++++++++
>  1 file changed, 73 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
> new file mode 100644
> index 000000000000..db13c56b77b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue-debug.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier SoC-glue logic debug part
> +
> +maintainers:
> +  - Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> +
> +description: |+
> +  SoC-glue logic debug part implemented on Socionext UniPhier SoCs is
> +  a collection of miscellaneous function registers handling signals outside
> +  system components for debug and monitor use.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - socionext,uniphier-ld4-soc-glue-debug
> +          - socionext,uniphier-pro4-soc-glue-debug
> +          - socionext,uniphier-pro5-soc-glue-debug
> +          - socionext,uniphier-pxs2-soc-glue-debug
> +          - socionext,uniphier-sld8-soc-glue-debug
> +          - socionext,uniphier-ld11-soc-glue-debug
> +          - socionext,uniphier-ld20-soc-glue-debug
> +          - socionext,uniphier-pxs3-soc-glue-debug
> +          - socionext,uniphier-nx1-soc-glue-debug
> +      - const: simple-mfd
> +      - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 1
> +
> +  ranges: true
> +
> +patternProperties:
> +  "^efuse(@[0-9a-f]+)?$":

Unit addresses are not optional.

Best regards,
Krzysztof