Re: [PATCH v2 06/22] sched/fair: Collect load-balancing stats for IPC classes

From: Ionela Voinescu
Date: Thu Dec 08 2022 - 03:50:32 EST


Hi,

On Monday 28 Nov 2022 at 05:20:44 (-0800), Ricardo Neri wrote:
[..]
>
> +struct sg_lb_ipcc_stats {
> + int min_score; /* Min(score(rq->curr->ipcc)) */
> + int min_ipcc; /* Min(rq->curr->ipcc) */

Nit: this is not the minimum IPCC between the current tasks of all
runqueues, but the IPCC specific to the task with the minimum score.

Possibly there's not much to be done about the variable name, but the
comment can be made more clear.

Thanks,
Ionela.

> + long sum_score; /* Sum(score(rq->curr->ipcc)) */
> +};
[..]