Re: [PATCH v2 1/3] serial: earlycon-arm-semihost: Move smh_putc() variants in respective arch's semihost.h

[Jiri Slaby]

On 08. 12. 22, 10:32, Bin Meng wrote:
> > > +#ifdef CONFIG_THUMB2_KERNEL
> > > +#define SEMIHOST_SWI    "0xab"
> > > +#else
> > > +#define SEMIHOST_SWI    "0x123456"
> > > +#endif
> > > +
> > > +static inline void smh_putc(struct uart_port *port, unsigned char c)
> >
> > 2) port is unused in all implementations. So it should be dropped.
> > 3) can you make "c" an explicit u8?
>
> The smh_putc function signature is defined by the uart_console_write 
> helper. I don't think we can change it.

Ah. Of course. Then at least forward-declare struct uart_port here. So 
that it works also when someone decides to include the header outside 
serial.

thanks,
--
js
suse labs