Re: [PATCH v3 2/2] arm64: dts: qcom: Add configuration for PMI8950 peripheral

From: Marijn Suijten
Date: Thu Dec 08 2022 - 05:13:03 EST


On 2022-12-04 17:19:05, Luca Weiss wrote:
> On Freitag, 2. Dezember 2022 10:36:58 CET Marijn Suijten wrote:
> [..]
>
> So the way this patch does it is good or does it need changes?

Except the typo(s?) pointed out in my first reply, this is good to go.

If we stick with generic adc-chan node names that should be documented
in the bindings IMO, as it is currently only captured implicitly in the
examples. Krzysztof, what is your thought on this?

- Marijn