Re: [PATCH] leds: qcom,pm8058-led: Convert to DT schema

From: Krzysztof Kozlowski
Date: Thu Dec 08 2022 - 05:19:56 EST


On 08/12/2022 11:09, Lee Jones wrote:
> On Wed, 07 Dec 2022, Pavel Machek wrote:
>
>> On Thu 2022-12-01 18:08:58, Rob Herring wrote:
>>> On Thu, Dec 01, 2022 at 02:15:05PM +0100, Krzysztof Kozlowski wrote:
>>>> Convert the Qualcomm PM8058 PMIC LED bindings to DT schema.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>>> ---
>>>> .../devicetree/bindings/leds/leds-pm8058.txt | 67 -------------------
>>>> .../bindings/leds/qcom,pm8058-led.yaml | 57 ++++++++++++++++
>>>> .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 4 ++
>>>> 3 files changed, 61 insertions(+), 67 deletions(-)
>>>> delete mode 100644 Documentation/devicetree/bindings/leds/leds-pm8058.txt
>>>> create mode 100644 Documentation/devicetree/bindings/leds/qcom,pm8058-led.yaml
>>>
>>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>>>
>>> Or should I apply it?
>>
>> Thanks for ACK, let me take it, I guess.
>
> Did you see Krzysztof's replies to this patch?
>
> Sounded like he was going to re-work it, which is why I left it.

The only rework needed was to add "dt-bindings:" prefix in the subject.
If you could add it while applying/amending commit, that would be great
and spare me resend. Otherwise, let me know if you dropped this patch
and expect a resend.

Best regards,
Krzysztof