Re: [PATCH 2/2][v2] cpuidle-haltpoll: Build as module by default

From: Rafael J. Wysocki
Date: Thu Dec 08 2022 - 06:43:10 EST


On Thu, Dec 8, 2022 at 3:32 AM Li,Rongqing <lirongqing@xxxxxxxxx> wrote:
>
>
> > > Allow user to unload it in running
> >
> > Just like that? And corrupt things left and right while at it?
> >
> > No way.
> >
> > And why do you need this?
>
> Cpuidle-haltpoll can not improve performance for all cases, like when guest has mwait, unixbench shows a small performance drop;
> So change it as module, user can insmod this drivers and rmmod this driver at run time

That is problematic, because in the mainline Linux kernel (which is
what we are talking about here) there is no support for modular
cpuidle governors.

Also, there is an interface for switching cpuidle governors at run
time already, so why can 't it be used to address this case?

> And some downstream os, centos and ubuntu build it module

Well, it's their problem.