Re: [PATCH] thermal/int340x_thermal: Convert to use sysfs_emit_at() API

[Rafael J. Wysocki]

On Thu, Dec 8, 2022 at 10:07 AM <ye.xingchen@xxxxxxxxxx> wrote:
>
> From: ye xingchen <ye.xingchen@xxxxxxxxxx>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx>

Well, you've clearly not taken my feedback into account.

Please resend this after 6.2-rc1 is out.  It will not be acted upon till then.

> ---
>  .../thermal/intel/int340x_thermal/int3400_thermal.c    | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index db8a6f63657d..c1fc4a78607c 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -130,10 +130,7 @@ static ssize_t available_uuids_show(struct device *dev,
>
>         for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; i++) {
>                 if (priv->uuid_bitmap & (1 << i))
> -                       length += scnprintf(&buf[length],
> -                                           PAGE_SIZE - length,
> -                                           "%s\n",
> -                                           int3400_thermal_uuids[i]);
> +                       length += sysfs_emit_at(buf, length, int3400_thermal_uuids[i]);
>         }
>
>         return length;
> @@ -151,10 +148,7 @@ static ssize_t current_uuid_show(struct device *dev,
>
>         for (i = 0; i <= INT3400_THERMAL_CRITICAL; i++) {
>                 if (priv->os_uuid_mask & BIT(i))
> -                       length += scnprintf(&buf[length],
> -                                           PAGE_SIZE - length,
> -                                           "%s\n",
> -                                           int3400_thermal_uuids[i]);
> +                       length += sysfs_emit_at(buf, length, int3400_thermal_uuids[i]);
>         }
>
>         if (length)
> --
> 2.25.1