Re: [PATCH net-next v4 1/2] macsec: add support for IFLA_MACSEC_OFFLOAD in macsec_changelink

[Jiri Pirko]

Thu, Dec 08, 2022 at 12:55:16PM CET, ehakim@xxxxxxxxxx wrote:
>From: Emeel Hakim <ehakim@xxxxxxxxxx>
>
>Add support for changing Macsec offload selection through the
>netlink layer by implementing the relevant changes in
>macsec_changelink.
>
>Since the handling in macsec_changelink is similar to macsec_upd_offload,
>update macsec_upd_offload to use a common helper function to avoid
>duplication.
>
>Example for setting offload for a macsec device:
>    ip link set macsec0 type macsec offload mac
>
>Reviewed-by: Raed Salem <raeds@xxxxxxxxxx>
>Signed-off-by: Emeel Hakim <ehakim@xxxxxxxxxx>

Looks fine to me.
Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>