Re: [PATCH v2] sched/fair: Fixes for capacity inversion detection

[Qais Yousef]

On 12/08/22 14:54, Qais Yousef wrote:
> Traversing the Perf Domains requires rcu_read_lock() to be held and is
> conditional on sched_energy_enabled(). rcu_read_lock() is held while in
> load_balance(), add an assert to ensure this is always the case.

Err that should say instead

	Traversing the Perf Domains requires rcu_read_lock() to be held and is
	conditional on sched_energy_enabled(). Ensure right protections applied.

Peter, let me know if you want me to resend with that fixed or happy to apply
yourself.


Thanks!

--
Qais Yousef

> 
> Also skip capacity inversion detection for our own pd; which was an
> error.
> 
> Fixes: 44c7b80bffc3 ("sched/fair: Detect capacity inversion")
> Reported-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
> Signed-off-by: Qais Yousef (Google) <qyousef@xxxxxxxxxxx>
> ---
> 
> Changes in v2:
> 
> 	* Make sure to hold rcu_read_lock() as we need it's not held in all
> 	  paths (thanks Dietmar!)