Re: [PATCH linux-next] net: ethernet: use strscpy() to instead of strncpy() 

From: Simon Horman
Date: Thu Dec 08 2022 - 11:13:52 EST


On Thu, Dec 08, 2022 at 07:52:03PM +0800, yang.yang29@xxxxxxxxxx wrote:
> From: Xu Panda <xu.panda@xxxxxxxxxx>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
>
> Signed-off-by: Xu Panda <xu.panda@xxxxxxxxxx>
> Signed-off-by: Yang Yang <yang.yang29@xxxxxxx>

This change looks good to me, but I think the subject should be:

[PATCH net-next] myri10ge: use strscpy() to instead of strncpy()

That not withstanding,

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>