Re: [PATCH] drivers/firmware_loader: remove list entry before deallocation

From: Greg KH
Date: Thu Dec 08 2022 - 13:18:32 EST


On Thu, Dec 08, 2022 at 05:18:15PM +0100, Michał Lach wrote:
> On 12/8/22 16:42, Greg KH wrote:
> > On Thu, Dec 08, 2022 at 04:23:52PM +0100, Michał Lach wrote:
> >> On 12/8/22 14:18, Greg KH wrote:
> >>> On Thu, Dec 08, 2022 at 11:45:28AM +0100, Michał Lach wrote:
> >>>> Pinging
> >>>
> >>> I have no context here at all.
> >>>
> >>> confused,
> >>
> >> It seems like my mail client messed up the encoding, sorry.
> >> Below quoting the patch message:
> >
> > Ok, but what does an empty ping here mean?
> >
> > Are you asking why no one else has reviewed this? Why it hasn't been
> > accepted? What else needs to happen? Something else?
> >
>
> It was kind of meant to bump it for other reviewers to review/accept
> this. Please correct me if this is against the netiquette here or
> should I just mention the reason for the ping in the first place.

Please think about what you would want to see sent to you. A "naked"
ping has no context at all, right?

How about a normal "It's been two weeks, anything else I need to do here
to get this merged?" sentance would be great.

And to help maintainer's workload, why not help out and review other
patches submitted? That's the best way to help ensure that a
maintainer's workload is reduced, and help make your patches move to the
top of the list.

thanks,

greg k-h