Re: [PATCH 1/2] mfd: qcom_rpm: Fix an error handling path in qcom_rpm_probe()

[Christophe JAILLET]

Le 08/12/2022 à 13:30, Lee Jones a écrit :
> On Sun, 20 Nov 2022, Christophe JAILLET wrote:
>
> > If an error occurs after the clk_prepare_enable() call, a corresponding
> > clk_disable_unprepare() should be called.
> >
> > Simplify code and switch to devm_clk_get_enabled() to fix it.
> >
> > Fixes: 3526403353c2 ("mfd: qcom_rpm: Handle message RAM clock")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> > ---
> > This changes the order of the clean-ups if the .remove() function is called
> > but it looks fine to me.
> > ---
> >   drivers/mfd/qcom_rpm.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
>
> Something funny going on here.
>
> I received 3 identical versions of the same patch.

Yes, was my fault.

Sorry for the inconvenience.

CJ