RE: [PATCH v2 1/6] x86/tdx: Retry TDVMCALL_MAP_GPA() when needed

From: Dexuan Cui
Date: Thu Dec 08 2022 - 14:54:36 EST


> From: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
> Sent: Thursday, December 8, 2022 11:48 AM
> To: Dexuan Cui <decui@xxxxxxxxxxxxx>
> > [...]
> > +static bool tdx_map_gpa(phys_addr_t start, phys_addr_t end, bool enc)
> > {
> > - phys_addr_t start = __pa(vaddr);
> > - phys_addr_t end = __pa(vaddr + numpages * PAGE_SIZE);
> > + int max_retry_cnt = 1000, retry_cnt = 0;
>
> Hm. max_retry_cnt looks too high to me. I expected to see 3 or something.
>
> Any justification for it to be *that* high?

No. I just used an enough big number :-)
I'll change it to 3 in the next version.