Re: [PATCH net-next 2/2] net: ipa: add IPA v4.7 support

[Konrad Dybcio]

On 8.12.2022 22:15, Alex Elder wrote:
> Add the necessary register and data definitions needed for IPA v4.7,
> which is found on the SM6350 SoC.
> 
> Co-developed-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> Signed-off-by: Alex Elder <elder@xxxxxxxxxx>
> ---
[...]
> +
> +/* Memory configuration data for an SoC having IPA v4.7 */
> +static const struct ipa_mem_data ipa_mem_data = {
> +	.local_count	= ARRAY_SIZE(ipa_mem_local_data),
> +	.local		= ipa_mem_local_data,
> +	.imem_addr	= 0x146a9000,
> +	.imem_size	= 0x00002000,
Should probably be

0x146a8000
0x00003000

with an appropriate change in dt to reserve that region.

Qualcomm does:
ipa@... { qcom,additional-mapping = <0x146a8000 0x146a8000 0x2000>; };

which covers 0x146a8000-0x146a9fff

plus

imem@.. { reg = <0x146aa000 0x1000>; };

which in total gives us 0x146a8000-0x146aafff


That would also mean all of your writes are kind of skewed, unless
you already applied some offsets to them.

(IMEM on 6350 starts at 0x14680000 and is 0x2e000 long, as per
the bootloader memory map)

Konrad