Re: [PATCH v2] tracing: Add trace_trigger kernel command line option

From: Steven Rostedt
Date: Thu Dec 08 2022 - 18:42:39 EST


On Thu, 8 Dec 2022 15:27:07 -0700
Ross Zwisler <zwisler@xxxxxxxxxx> wrote:

> > +#ifdef CONFIG_HIST_TRIGGERS
>
> Can you help me understand why this is only available if
> CONFIG_HIST_TRIGGERS is selected in the kernel config? AFAICT this
> code doesn't depend on the histogram code, and the run-time selection
> of triggers is usable without CONFIG_HIST_TRIGGERS.

Good catch!

I got confused, and only saw that as "CONFIG_TRIGGERS" and wasn't thinking
that config was just for histogram triggers :-p

Care to send a patch to fix it?

Thanks Ross,

-- Steve