Re: [PATCH 3/5] swap: fold swap_ra_clamp_pfn into swap_ra_info

From: Kairui Song
Date: Thu Dec 08 2022 - 21:00:20 EST


Matthew Wilcox <willy@xxxxxxxxxxxxx> 于2022年12月9日周五 03:09写道:
>
> On Fri, Dec 09, 2022 at 02:02:07AM +0800, Kairui Song wrote:
> > From: Kairui Song <kasong@xxxxxxxxxxx>
> >
> > This make the code cleaner. This helper is made of only two line of
> > self explanational code and not reused anywhere else.
> >
> > And this actually make the compiled object smaller by a bit:
> >
> > text data bss dec hex filename
> > Before: 9502 976 12 10490 28fa mm/swap_state.o
> > After: 9470 976 12 10458 28da mm/swap_state.o
>
> FYI, you can use scripts/bloat-o-meter to get a slightly more
> useful analysis of object code changes.
>

Thanks! That's very helpful info, I got following output from bloat-o-meter:

./scripts/bloat-o-meter mm/swap_state.o.old mm/swap_state.o
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-35 (-35)
Function old new delta
swap_ra_info.constprop 512 477 -35
Total: Before=8388, After=8353, chg -0.42%

I'll attach this info in commit message from now on.