Re: [PATCH net-next] net: tso: inline tso_count_descs()

From: Jakub Kicinski
Date: Thu Dec 08 2022 - 23:00:06 EST


On Thu, 8 Dec 2022 19:57:21 -0800 Jakub Kicinski wrote:
> On Thu, 8 Dec 2022 10:43:03 +0800 Yunsheng Lin wrote:
> > tso_count_descs() is a small function doing simple calculation,
> > and tso_count_descs() is used in fast path, so inline it to
> > reduce the overhead of calls.
>
> TSO frames are large, the overhead is fine.
> I'm open to other opinions but I'd rather keep the code as is than
> deal with the influx with similar sloppily automated changes.

Oh, wait, you're not one of the bot people. Sorry, please just address
my comments and post a v2.

There is a lot of poorly written patches coming from @huawei addresses
which are giving the company a bad name :(