Re: security: policy_unpack.c:325:10: error: use of undeclared identifier 'TRI_TRUE'

[John Johansen]

On 12/8/22 22:57, David Gow wrote:
> On Thu, 8 Dec 2022 at 15:36, Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> wrote:
> > Following build regresion found on Linux next-20221208 tag.
> >
> > Regressions found on riscv:
> >    - build/clang-nightly-defconfig
> >    - build/gcc-8-defconfig
> >    - build/gcc-11-defconfig
> >    - build/clang-15-defconfig
> >
> > make --silent --keep-going --jobs=8
> > O=/home/tuxbuild/.cache/tuxmake/builds/1/build LLVM=1 LLVM_IAS=1
> > ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- 'HOSTCC=sccache clang'
> > 'CC=sccache clang' defconfig
> > make --silent --keep-going --jobs=8
> > O=/home/tuxbuild/.cache/tuxmake/builds/1/build LLVM=1 LLVM_IAS=1
> > ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- 'HOSTCC=sccache clang'
> > 'CC=sccache clang'
> > security/apparmor/policy_unpack.c:316:18: error: unknown type name 'tri'
> > VISIBLE_IF_KUNIT tri aa_unpack_array(struct aa_ext *e, const char
> > *name, u16 *size)
> >                   ^
> > security/apparmor/policy_unpack.c:325:10: error: use of undeclared
> > identifier 'TRI_TRUE'
> >                  return TRI_TRUE;
> >                         ^
> > security/apparmor/policy_unpack.c:328:9: error: use of undeclared
> > identifier 'TRI_NONE'
> >          return TRI_NONE;
> >                 ^
> > security/apparmor/policy_unpack.c:331:9: error: use of undeclared
> > identifier 'TRI_FALSE'
> >          return TRI_FALSE;
> >                 ^
> > security/apparmor/policy_unpack.c:455:42: error: use of undeclared
> > identifier 'TRI_TRUE'
> >                  if (aa_unpack_array(e, NULL, &size) != TRI_TRUE)
> >                                                         ^
> > security/apparmor/policy_unpack.c:529:42: error: use of undeclared
> > identifier 'TRI_TRUE'
> >                  if (aa_unpack_array(e, NULL, &size) != TRI_TRUE)
> >                                                         ^
> > security/apparmor/policy_unpack.c:559:42: error: use of undeclared
> > identifier 'TRI_TRUE'
> >                  if (aa_unpack_array(e, NULL, &size) != TRI_TRUE)
> >                                                         ^
> > security/apparmor/policy_unpack.c:611:42: error: use of undeclared
> > identifier 'TRI_TRUE'
> >                  if (aa_unpack_array(e, NULL, &size) != TRI_TRUE ||
> >                                                         ^
> > security/apparmor/policy_unpack.c:674:42: error: use of undeclared
> > identifier 'TRI_TRUE'
> >                  if (aa_unpack_array(e, NULL, &size) != TRI_TRUE)
> >                                                         ^
> > 9 errors generated.
> > make[4]: *** [scripts/Makefile.build:252:
> > security/apparmor/policy_unpack.o] Error 1
> > make[4]: Target 'security/apparmor/' not remade because of errors.
> > make[3]: *** [scripts/Makefile.build:504: security/apparmor] Error 2
> >
> > Build link,
> >    - https://builds.tuxbuild.com/2IcJeyR3s4kGd2Nca8vVq7Sleao/
> >    - https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20221208/testrun/13508560/suite/build/test/gcc-11-defconfig/details/
> >
> > Build results comparison:
> >    - https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20221208/testrun/13508560/suite/build/test/gcc-11-defconfig/history/
> >
> >
> > steps to reproduce:
> > # To install tuxmake on your system globally:
> > # sudo pip3 install -U tuxmake
> > #
> > # See https://docs.tuxmake.org/ for complete documentation.
> > # Original tuxmake command with fragments listed below.
> > # tuxmake --runtime podman --target-arch riscv --toolchain gcc-11
> > --kconfig defconfig
> >
> >
> > tuxmake --runtime podman --target-arch riscv --toolchain gcc-11
> > --kconfig https://builds.tuxbuild.com/2IcJeyR3s4kGd2Nca8vVq7Sleao/config
> >
> > --
> > Linaro LKFT
> > https://lkft.linaro.org
>
> I suspect this is in need of the fix here:
> https://lore.kernel.org/all/bff89220-df3a-a148-2ba4-6aad3874f322@xxxxxxxxxxxxx/

yes, that is what is needed to fix this