RE: [PATCH net-next v4 1/2] macsec: add support for IFLA_MACSEC_OFFLOAD in macsec_changelink

[Emeel Hakim]

> -----Original Message-----
> From: Emeel Hakim
> Sent: Friday, 9 December 2022 12:19
> To: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Raed Salem <raeds@xxxxxxxxxx>;
> davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; sd@xxxxxxxxxxxxxxx; atenart@xxxxxxxxxx; jiri@xxxxxxxxxxx
> Subject: RE: [PATCH net-next v4 1/2] macsec: add support for
> IFLA_MACSEC_OFFLOAD in macsec_changelink
> 
> 
> 
> > -----Original Message-----
> > From: Jakub Kicinski <kuba@xxxxxxxxxx>
> > Sent: Friday, 9 December 2022 4:33
> > To: Emeel Hakim <ehakim@xxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; Raed Salem <raeds@xxxxxxxxxx>;
> > davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> > netdev@xxxxxxxxxxxxxxx; sd@xxxxxxxxxxxxxxx; atenart@xxxxxxxxxx;
> > jiri@xxxxxxxxxxx
> > Subject: Re: [PATCH net-next v4 1/2] macsec: add support for
> > IFLA_MACSEC_OFFLOAD in macsec_changelink
> >
> > External email: Use caution opening links or attachments
> >
> >
> > On Thu, 8 Dec 2022 18:32:44 -0800 Jakub Kicinski wrote:
> > > I think you're just moving this code, but still.
> >
> > And by "by still" I mean - it's still a bug, so it needs to be fixed first.
> 
> The code added by those patches does not use the rtnl_lock, the lock is just getting
> moved as part of sharing similar code, but the new code is still not using it, I don’t
> think those  patches need to wait until a fix of an existing locking issue as long as
> the new code is not inserting any bugs.

I will send a fix patch shortly as requested.