Re: [PATCH v1] ASoC: Intel: sof_nau8825: add support for nau8825 with amp nau8318

[Ajye Huang]

HI Pierre,

On Sat, Dec 10, 2022 at 1:31 AM Pierre-Louis Bossart
<pierre-louis.bossart@xxxxxxxxxxxxxxx> wrote:

> Suggested edit:
>
> ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier.
>

> That should be added in the commit message please.
>

Thank you for the suggestion title and I will add those explanations
in the comment message.

> Ok, makes sense now. Please do include the explanations on 8315/8318
> variants, I couldn't figure out what chips were used.
>
> I would also not use the same topology name as a different platform with
> another amplifier. I appreciate you trying to reuse when possible, but
> it's just better to create a new topology file. That way if you want any
> update down the road you can do so, it's more maintainable and risk-free.

OK, The v2 patch will be sent after the new topology file is created. Thank you.