Re: [PATCH v2 2/4] objtool: Install libsubcmd in build

[Nick Desaulniers]

On Mon, Nov 21, 2022 at 4:11 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> +ifneq ($(OUTPUT),)
> +  LIBSUBCMD_OUTPUT = $(abspath $(OUTPUT))/libsubcmd
> +else
> +  LIBSUBCMD_OUTPUT = $(CURDIR)/libsubcmd
> +endif

Seeing an else clause when the predicate is negated makes this read as:

if !foo:
  baz()
else:
  bar()

Consider using:

if foo:
  bar()
else
  baz()

in the future.
-- 
Thanks,
~Nick Desaulniers